Complete Cache/CacheDependency implementation and add additional tests. #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dency) Fix issue when there are no cachedependencies when calculating utcLastModified
4 tasks
twsouthwick
approved these changes
Jun 5, 2023
…ath to ensure ChangeMonitors are always handled. To support custom CacheDependency types that might not use change monitors under the surface, always call GetChangeMonitor and add it to the policy's change monitors.
Contributor
Author
|
If anyone needs |
Member
Feel free to open a PR for that - if you've needed it, it's likely others will as well. Thanks for your contributions here @CZEMacLeod ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete Cache/CacheDependency implementation to cover additional scenarios
System.Web.Caching.Cache- Support for dependencies (implemented via ChangeMonitors)System.Web.Caching.Cache- Add missing Insert methodSystem.Web.Caching.CacheDependency- Add additional constructor overloads (and correct accessibility of 'empty' constructor)System.Web.Caching.CacheDependency- Fix issue when start date is not suppliedAdd tests for dependent files, and for dependent items
Add tests for cache insert
Fix issue when a
CacheDependencyhas no changeMonitorsAddresses #347 and #350